Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3296003: FBTF: Move the TabRestoreService::Observer into its own file. (Closed)

Created:
10 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Move the TabRestoreService::Observer into its own file. This means browser.h no longer includes a large chunk of the tab restore system. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58256

Patch Set 1 #

Patch Set 2 : Missing file #

Patch Set 3 : win fixes #

Patch Set 4 : mac compile fixes #

Patch Set 5 : More mac fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -64 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/history_menu_bridge.h View 1 2 3 4 chunks +7 lines, -15 lines 0 comments Download
M chrome/browser/cocoa/history_menu_bridge.mm View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/view_id_util_browsertest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_proxy_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/jumplist_win.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_backend.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 2 chunks +7 lines, -18 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 4 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 3 chunks +7 lines, -4 lines 0 comments Download
A chrome/browser/sessions/tab_restore_service_observer.h View 2 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
10 years, 3 months ago (2010-09-01 20:34:44 UTC) #1
Lei Zhang
LGTM, but I defer to Ben on whether to move TabRestoreService::Observer.
10 years, 3 months ago (2010-09-01 20:38:44 UTC) #2
Ben Goodger (Google)
10 years, 3 months ago (2010-09-01 22:43:19 UTC) #3 
OK

Powered by Google App Engine
This is Rietveld 408576698