Issue 3296001: Get size using --get-size in flashrom_util.py instead of reading whole flash.

Issue 3296001: Get size using --get-size in flashrom_util.py instead of reading whole flash. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Hung-Te, dhendrix, Louis

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Get size using --get-size in flashrom_util.py instead of reading whole flash. Also restore to BIOS after running firmware_RomSize test. TEST=run firmware_RomSize test in AGZ and non-Mario. Change-Id: I876842b9670cc0c2294781e859e239a90598d33e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add mock implementation of system_output #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -15 lines)			Patch
	M	client/common_lib/flashrom_util.py	View	1	2 chunks	+23 lines, -14 lines	2 comments	Download
	M	client/site_tests/firmware_RomSize/firmware_RomSize.py	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM except a minor mock better to be added. http://codereview.chromium.org/3296001/diff/1/2 File client/common_lib/flashrom_util.py (right): http://codereview.chromium.org/3296001/diff/1/2#newcode331 client/common_lib/flashrom_util.py:331: ...

10 years, 3 months ago (2010-09-01 02:01:34 UTC) #2

Tom Wai-Hong Tam

http://codereview.chromium.org/3296001/diff/1/2 File client/common_lib/flashrom_util.py (right): http://codereview.chromium.org/3296001/diff/1/2#newcode331 client/common_lib/flashrom_util.py:331: output = utils.system_output(cmd, ignore_status=True) On 2010/09/01 02:01:34, Hung-Te wrote: ...

10 years, 3 months ago (2010-09-02 00:28:48 UTC) #3

Hung-Te

http://codereview.chromium.org/3296001/diff/5001/6001 File client/common_lib/flashrom_util.py (right): http://codereview.chromium.org/3296001/diff/5001/6001#newcode770 client/common_lib/flashrom_util.py:770: if p.returncode and not ignore_status: oops, please keep the ...

10 years, 3 months ago (2010-09-02 02:10:21 UTC) #4

Tom Wai-Hong Tam

10 years, 3 months ago (2010-09-02 02:55:23 UTC) #5

http://codereview.chromium.org/3296001/diff/5001/6001
File client/common_lib/flashrom_util.py (right):

http://codereview.chromium.org/3296001/diff/5001/6001#newcode770
client/common_lib/flashrom_util.py:770: if p.returncode and not ignore_status:
OK. Will change it in other CL: http://codereview.chromium.org/3343003

Expand Messages | Collapse Messages