Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 3294021: Increased threads to 50, added update timestamp for HTML pages. (Closed)

Created:
10 years, 3 months ago by kdlucas
Modified:
9 years, 7 months ago
Reviewers:
ericli
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://git@chromiumos-git//autotest.git
Visibility:
Public.

Description

Increased threads to 50, added update timestamp for HTML pages. BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved capture of timestamp to end of run. #

Patch Set 3 : Increased timeout when creating graphics. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M utils/monitor.py View 1 2 7 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kdlucas
10 years, 3 months ago (2010-09-10 21:22:01 UTC) #1
ericli
what is the motivation to increase it? http://codereview.chromium.org/3294021/diff/1/2 File utils/monitor.py (right): http://codereview.chromium.org/3294021/diff/1/2#newcode159 utils/monitor.py:159: TB.hosts[self.h]['time'] = ...
10 years, 3 months ago (2010-09-10 21:27:03 UTC) #2
kdlucas
I increased threads to 50 as I was seeing significantly better performance when using 50 ...
10 years, 3 months ago (2010-09-10 21:54:59 UTC) #3
ericli
10 years, 3 months ago (2010-09-10 23:03:08 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698