Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 3294007: Make delayed-permission-denied-for-multiple-requests pass (Closed)

Created:
10 years, 3 months ago by joth
Modified:
9 years, 7 months ago
Reviewers:
bulach, jorlow, steveblock
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Make delayed-permission-denied-for-multiple-requests pass Enqueue permission requests until the first setPermission call is received. BUG=webkit 43480 TEST=fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58631

Patch Set 1 #

Patch Set 2 : Add expectation override #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_geolocation_service.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_geolocation_service.cc View 1 2 chunks +27 lines, -10 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
joth
As a side effect of my other fixes, I worked this one out.
10 years, 3 months ago (2010-09-03 14:24:56 UTC) #1
steveblock
LGTM
10 years, 3 months ago (2010-09-03 14:36:15 UTC) #2
jorlow
LGTM
10 years, 3 months ago (2010-09-06 10:52:48 UTC) #3
bulach
LGTM thanks joth! minor question below, we probably want to do something similar for the ...
10 years, 3 months ago (2010-09-06 11:51:47 UTC) #4
joth
10 years, 3 months ago (2010-09-06 12:08:57 UTC) #5
Just to clarify, let me know if you still had a query about this.

http://codereview.chromium.org/3294007/diff/2001/3002
File webkit/tools/test_shell/test_geolocation_service.cc (right):

http://codereview.chromium.org/3294007/diff/2001/3002#newcode60
webkit/tools/test_shell/test_geolocation_service.cc:60: DCHECK(bridge);
On 2010/09/06 11:51:48, bulach wrote:
> not entirely sure why you're copying the vector, is it because the bridge can
be
> detached while traversing it? perhaps then remove this DCHECK with an if?

I'm not copying the vector, I'm swapping it (important difference)
 I just find it cleaner style and easier to reason about this way.

Powered by Google App Engine
This is Rietveld 408576698