Add recursive flag to file_util_proxy::CreateDirectory

Add recursive flag to file_util_proxy::CreateDirectory.

BUG=54352
TEST=all the FileSystemOperationTest.TestCreateDir* should continue to pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58781

[Kavita Kanetkar, 2010-09-03 18:02:04]

http://codereview.chromium.org/3293009/diff/1/2
File base/file_util_proxy.cc (right):

http://codereview.chromium.org/3293009/diff/1/2#newcode336
base/file_util_proxy.cc:336:
set_error_code(base::PLATFORM_FILE_ERROR_NOT_FOUND);
If it's recursive and parent dir doesn't exist it won't return a not found
error. Is that intentional?

http://codereview.chromium.org/3293009/diff/1/4
File chrome/browser/file_system/file_system_backend.cc (right):

http://codereview.chromium.org/3293009/diff/1/4#newcode55
chrome/browser/file_system/file_system_backend.cc:55: path, exclusive, false,
callback_factory_.NewCallback(
Can we add /* recursive */ ?

http://codereview.chromium.org/3293009/diff/1/4#newcode190
chrome/browser/file_system/file_system_backend.cc:190: }
Was this newline deletion intentional?

[kinuko, 2010-09-03 18:17:15]

http://codereview.chromium.org/3293009/diff/1/2
File base/file_util_proxy.cc (right):

http://codereview.chromium.org/3293009/diff/1/2#newcode336
base/file_util_proxy.cc:336:
set_error_code(base::PLATFORM_FILE_ERROR_NOT_FOUND);
On 2010/09/03 18:02:04, Kavita Kanetkar wrote:
> If it's recursive and parent dir doesn't exist it won't return a not found
> error. Is that intentional?

It's got '!' - so it's returning not found error if it's NOT recursive and
parent dir doesn't exist.

http://codereview.chromium.org/3293009/diff/1/4
File chrome/browser/file_system/file_system_backend.cc (right):

http://codereview.chromium.org/3293009/diff/1/4#newcode55
chrome/browser/file_system/file_system_backend.cc:55: path, exclusive, false,
callback_factory_.NewCallback(
On 2010/09/03 18:02:04, Kavita Kanetkar wrote:
> Can we add /* recursive */ ?

Done.

http://codereview.chromium.org/3293009/diff/1/4#newcode190
chrome/browser/file_system/file_system_backend.cc:190: }
On 2010/09/03 18:02:04, Kavita Kanetkar wrote:
> Was this newline deletion intentional?

Partly (my editor does that).
Basically a newline needs to exist at the end of the last line (line 190) but no
need to add an extra one.

In yesterday's case I wanted to make sure it has at least one newline at the end
of file so I let it go with extra newline.

[kinuko, 2010-09-07 21:55:59]

ping... wonder if it looks good now?

Thx,

[Kavita Kanetkar, 2010-09-07 22:10:19]

LGTM