Issue 3292003: De-suck the NTP a bit more:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3292003: De-suck the NTP a bit more: (Closed)

Created:
10 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

De-suck the NTP a bit more: * When there are no apps, don't show the apps section. * Expand the MV section by default, like it was in M6. * Fix bug where recently closed is incorrectly toggleable. * Stop showing miniview items for MV section when there is no more room. * Don't show filler MV items in miniview. * MV section is 5px too high because we were only apply extra padding to the first section, even if that section was disabled. TEST=Visual inspection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58139

Patch Set 1 #

Patch Set 2 : Fix unit test #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -18 lines)			Patch
M	chrome/browser/dom_ui/new_tab_ui.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.cc	View	1	1 chunk	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler_unittest.cc	View		1 chunk	+22 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp/most_visited.js	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages