Display summary and failed tests results

Display summary and failed tests results

I rewrite factory_Review that
* it displays status of all tests results, including sub-tests of
  run-in, etc.
* it displays detailed reason of failure; scroll by j/k.

BUG=chrome-os-partner:379
TEST=run factory test and press Ctrl-Z (switch to review directly)

Screenshot is attached to bug tracker.

Note:
The factory_ui on your machine would not be the same with
the screenshot.

Change-Id: I283208d356be6c41d44577b61c19e413e366ee50

[Tammo Spalink, 2010-09-07 02:12:40]

have not tested this yet, as my machine is hosed, but the picture looks very
pretty

some minor comments below

will lgtm once I get a chance to run it

http://codereview.chromium.org/3291011/diff/7001/8001
File client/site_tests/factory_Review/factory_Review.py (right):

http://codereview.chromium.org/3291011/diff/7001/8001#newcode65
client/site_tests/factory_Review/factory_Review.py:65: msg_zw =
t.label_zw.decode('utf8')
can you explain what this actually does?  do we need to be doing this in other
places too?

http://codereview.chromium.org/3291011/diff/7001/8001#newcode84
client/site_tests/factory_Review/factory_Review.py:84: msg = '%s (%s)\n%s' %
(t.label_en, t.label_zw, status_map.lookup_error_msg(t))
>80 chars

[Tammo Spalink, 2010-09-07 08:06:04]

http://codereview.chromium.org/3291011/diff/7001/8001
File client/site_tests/factory_Review/factory_Review.py (right):

http://codereview.chromium.org/3291011/diff/7001/8001#newcode80
client/site_tests/factory_Review/factory_Review.py:80:
vbox.pack_start(status_table, False, False)
it would be nice if there was a small margin around the tab contents, currently
the contents looks flush with the left and top borders of the tab -- not sure
the best place to add some margin, maybe config the notebook, or add a
surrounding box here?

http://codereview.chromium.org/3291011/diff/7001/8001#newcode95
client/site_tests/factory_Review/factory_Review.py:95: if event.keyval ==
ord('j'):
can you reverse these?  they seem backwards...

http://codereview.chromium.org/3291011/diff/7001/8001#newcode136
client/site_tests/factory_Review/factory_Review.py:136:
vbox.pack_start(control_label, False, False)
this is not displaying for me...

[clchiou, 2010-09-08 06:06:08]

Thanks for the comments, Tammo.

http://codereview.chromium.org/3291011/diff/7001/8001
File client/site_tests/factory_Review/factory_Review.py (right):

http://codereview.chromium.org/3291011/diff/7001/8001#newcode65
client/site_tests/factory_Review/factory_Review.py:65: msg_zw =
t.label_zw.decode('utf8')
On 2010/09/07 02:12:40, Tammo Spalink wrote:
> can you explain what this actually does?  do we need to be doing this in other
> places too?

Removed.  This was remnant; in previous version I had tried to trim msg_zw
(msg_zw[:length]) so I had had to decode it into a unicode string, but then I
found that msg_zw were short enough and no slicing was needed.

http://codereview.chromium.org/3291011/diff/7001/8001#newcode80
client/site_tests/factory_Review/factory_Review.py:80:
vbox.pack_start(status_table, False, False)
On 2010/09/07 08:06:04, Tammo Spalink wrote:
> it would be nice if there was a small margin around the tab contents,
currently
> the contents looks flush with the left and top borders of the tab -- not sure
> the best place to add some margin, maybe config the notebook, or add a
> surrounding box here?

Done.  Set border width of tabs.

http://codereview.chromium.org/3291011/diff/7001/8001#newcode84
client/site_tests/factory_Review/factory_Review.py:84: msg = '%s (%s)\n%s' %
(t.label_en, t.label_zw, status_map.lookup_error_msg(t))
On 2010/09/07 02:12:40, Tammo Spalink wrote:
> >80 chars

Done.

http://codereview.chromium.org/3291011/diff/7001/8001#newcode95
client/site_tests/factory_Review/factory_Review.py:95: if event.keyval ==
ord('j'):
On 2010/09/07 08:06:04, Tammo Spalink wrote:
> can you reverse these?  they seem backwards...

Done.

http://codereview.chromium.org/3291011/diff/7001/8001#newcode136
client/site_tests/factory_Review/factory_Review.py:136:
vbox.pack_start(control_label, False, False)
On 2010/09/07 08:06:04, Tammo Spalink wrote:
> this is not displaying for me...

Fixed.  Dimension of self.notebook was too large.

[Tammo Spalink, 2010-09-08 08:50:18]

lgtm -- with extra verbal comment on size maximization

[clchiou, 2010-09-09 06:40:47]

On 2010/09/08 08:50:18, Tammo Spalink wrote:
> lgtm -- with extra verbal comment on size maximization

Done.  Commit.