Issue 329040: Take 2 at this. The only change between this and the first is to add the GetT...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329040: Take 2 at this. The only change between this and the first is to add the GetT... (Closed)

Created:
11 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Take 2 at this. The only change between this and the first is to add the GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30255

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -36 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	4 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/browser.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/defaults.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/defaults.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_restore_uitest.cc	View	3 chunks	+51 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/session_service.h	View	3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/sessions/session_service.cc	View	9 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/sessions/session_service_unittest.cc	View	2 chunks	+53 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_restore_uitest.cc	View	5 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_base.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/test/automation/automation_proxy.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/automation/automation_proxy.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/test/automation/browser_proxy.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/test/automation/browser_proxy.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages