Issue 329039: Prep the management page for localization....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329039: Prep the management page for localization.... (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prep the management page for localization. BUG=25947 TEST=Not easily testable until we have the strings localized. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30324

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -30 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View	1 2	2 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View	1 2	12 chunks	+47 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

11 years, 1 month ago (2009-10-27 23:36:07 UTC) #2

lgtm.

http://codereview.chromium.org/329039/diff/8/9
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/329039/diff/8/9#newcode2605
Line 2605: <message name="IDS_EXTENSIONS_DISABLED_EXTENSION" desc="Text that
signigies that the extension is currently disabled.">
typo: "signifies"

http://codereview.chromium.org/329039/diff/8/9#newcode2611
Line 2611: <message name="IDS_EXTENSIONS_VERSION" desc="The ID label in front if
the extension ID.">
incorrect desc

Expand Messages | Collapse Messages