Check cert_handle_ is not NULL to Verify()

Check cert_handle_ is not NULL to Verify()

If X509Certificate is created in URLRequestAutomationJob or
URLRequestInterceptJob, cert_handle_ is NULL.
So if such certificate is being to be verified (not sure it happens), it would cause crash or some
problem.

BUG=15614
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30319

[wtc, 2009-10-27 21:37:18]

LGTM.

http://codereview.chromium.org/329036/diff/1/2
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/329036/diff/1/2#newcode506
Line 506: if (!cert_handle_) {
Does the GetDNSNames method need to work with a null
cert_handle_?

Instead of adding lines 506-509, let's put lines 510-521
inside an if statement, like this:

  dns_names->clear();
  if (cert_handle_) {
    scoped_ptr_malloc<CERT_ALT_NAME_INFO> alt_name_info;
    ...
  }
  if (dns_names->empty())
    dns_names->push_back(subject_.common_name);

[ukai, 2009-10-28 03:37:07]

http://codereview.chromium.org/329036/diff/1/2
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/329036/diff/1/2#newcode506
Line 506: if (!cert_handle_) {
On 2009/10/27 21:37:18, wtc wrote:
> Does the GetDNSNames method need to work with a null
> cert_handle_?

I'm not sure, but I think it would be safe to use subject_ in such case.
> 
> Instead of adding lines 506-509, let's put lines 510-521
> inside an if statement, like this:
> 
>   dns_names->clear();
>   if (cert_handle_) {
>     scoped_ptr_malloc<CERT_ALT_NAME_INFO> alt_name_info;
>     ...
>   }
>   if (dns_names->empty())
>     dns_names->push_back(subject_.common_name);

Done.