GTK: Draw floating bookmark bar correctly during resizes....

chrome/browser/gtk/bookmark_bar_gtk.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GTK_BOOKMARK_BAR_GTK_H_
 #define CHROME_BROWSER_GTK_BOOKMARK_BAR_GTK_H_
 
 #include <gtk/gtk.h>
 
 #include <string>
 #include <vector>
 
 #include "app/slide_animation.h"
+#include "base/gfx/size.h"
 #include "base/scoped_ptr.h"
 #include "chrome/browser/bookmarks/bookmark_model_observer.h"
 #include "chrome/browser/gtk/menu_bar_helper.h"
 #include "chrome/browser/gtk/view_id_util.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
 #include "chrome/common/owned_widget_gtk.h"
 #include "testing/gtest/include/gtest/gtest_prod.h"
 
@@ skipping 119 matching lines @@
   // Returns true if the bookmark bar should be floating on the page (for
   // NTP).
   bool ShouldBeFloating();
   // Update the floating state (either enable or disable it, or do nothing).
   void UpdateFloatingState();
 
   // Turns on or off the app_paintable flag on |event_box_|, depending on our
   // state.
   void UpdateEventBoxPaintability();
 
+  // Queue a paint on the event box.
+  void PaintEventBox();
+
+  // Finds the size of the current tab contents. If the size cannot be found,
+  // DCHECKs and returns false. Otherwise, sets |size| to the correct value.
+  bool GetTabContentsSize(gfx::Size* size);
+
   // Overridden from BookmarkModelObserver:
 
   // Invoked when the bookmark model has finished loading. Creates a button
   // for each of the children of the root node from the model.
   virtual void Loaded(BookmarkModel* model);
 
   // Invoked when the model is being deleted.
   virtual void BookmarkModelBeingDeleted(BookmarkModel* model);
 
   // Invoked when a node has moved.
@@ skipping 75 matching lines @@
   // Used for both folder buttons and the toolbar.
   static void OnDragReceived(GtkWidget* widget,
                              GdkDragContext* context,
                              gint x, gint y,
                              GtkSelectionData* selection_data,
                              guint target_type, guint time,
                              BookmarkBarGtk* bar);
 
   // GtkEventBox callbacks.
   static gboolean OnEventBoxExpose(GtkWidget* widget, GdkEventExpose* event,
-                                   BookmarkBarGtk* window);
+                                   BookmarkBarGtk* bar);
 
   // GtkVSeparator callbacks.
   static gboolean OnSeparatorExpose(GtkWidget* widget, GdkEventExpose* event,
                                     BookmarkBarGtk* window);

[tony, 2009/10/26 23:55:30]

Nit: want to change this to |bar| as well?

 
+  // Callbacks on our parent widget.
+  static void OnParentSizeAllocate(GtkWidget* widget,
+                                   GtkAllocation* allocation,
+                                   BookmarkBarGtk* bar);
+
 #if defined(BROWSER_SYNC)
   // ProfileSyncServiceObserver method.
   virtual void OnStateChanged();
 
   // Determines whether the sync error button should appear on the bookmarks
   // bar.
   bool ShouldShowSyncErrorButton();
 
   // Creates the sync error button and adds it as a child view.
   GtkWidget* CreateSyncErrorButton();
@@ skipping 80 matching lines @@
   // Whether we are currently configured as floating (detached from the
   // toolbar). This reflects our actual state, and can be out of sync with
   // what ShouldShowFloating() returns.
   bool floating_;
 
   // Used to optimize out |bookmark_toolbar_| size-allocate events we don't
   // need to respond to.
   int last_allocation_width_;
 
   NotificationRegistrar registrar_;
+
+  // The size of the tab contents last time we forced a paint. We keep track
+  // of this so we don't force too many paints.
+  gfx::Size last_tab_contents_size_;
+
+  // We post delayed paints using this factory.
+  ScopedRunnableMethodFactory<BookmarkBarGtk> event_box_paint_factory_;
 };
 
 #endif  // CHROME_BROWSER_GTK_BOOKMARK_BAR_GTK_H_