Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3359)

Unified Diff: chrome/browser/views/tabs/tab_strip.cc

Issue 329021: Makes inactive pinned tabs throb on views when the title changes.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/tabs/tab_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/tab_strip.cc
===================================================================
--- chrome/browser/views/tabs/tab_strip.cc (revision 30064)
+++ chrome/browser/views/tabs/tab_strip.cc (working copy)
@@ -1056,6 +1056,10 @@
} else {
SchedulePaint();
}
+
+ int old_index = model_->GetIndexOfTabContents(old_contents);
+ if (old_index >= 0)
+ GetTabAt(old_index)->StopPinnedTabTitleAnimation();
}
}
@@ -1081,9 +1085,8 @@
// case we have an animation going.
Tab* tab = GetTabAtAdjustForAnimation(index);
if (change_type == TITLE_NOT_LOADING) {
- // TODO(sky): make this work.
- // if (tab->is_pinned() && !tab->IsSelected())
- // tab->StartPinnedTabTitleAnimation();
+ if (tab->pinned() && !tab->IsSelected())
+ tab->StartPinnedTabTitleAnimation();
// We'll receive another notification of the change asynchronously.
return;
}
« no previous file with comments | « chrome/browser/views/tabs/tab_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698