Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 329013: Implemented NPN_ScheduleTimer and NPN_UnscheduleTimer. (Closed)

Created:
11 years, 2 months ago by apatrick
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, jam, amit
Visibility:
Public.

Description

Implemented NPN_ScheduleTimer and NPN_UnscheduleTimer. TEST=none BUG=18020 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30105

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 16

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -19 lines) Patch
A chrome/test/data/npapi/schedule_timer.html View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/npapi/bindings/npapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/nphostapi.h View 2 chunks +8 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_instance.h View 1 2 3 4 4 chunks +24 lines, -1 line 0 comments Download
M webkit/glue/plugins/plugin_instance.cc View 1 2 3 4 4 chunks +73 lines, -14 lines 0 comments Download
M webkit/glue/plugins/test/plugin_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A webkit/glue/plugins/test/plugin_schedule_timer_test.h View 3 1 chunk +70 lines, -0 lines 0 comments Download
A webkit/glue/plugins/test/plugin_schedule_timer_test.cc View 3 4 1 chunk +116 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
apatrick
A few things... I mostly copied what NPN_PluginThreadAsyncCall does. Are there unit tests for the ...
11 years, 2 months ago (2009-10-23 20:55:40 UTC) #1
darin (slow to review)
I'd like to defer this code review to John.
11 years, 2 months ago (2009-10-23 21:26:12 UTC) #2
apatrick
Cool. I wonder if an interval of zero should be an error? Is it worth ...
11 years, 2 months ago (2009-10-23 21:30:43 UTC) #3
jam
regarding your questions: -no need to change WebKit for stuff like this -there are ui ...
11 years, 2 months ago (2009-10-23 22:09:39 UTC) #4
apatrick
Added some tests. These tests are timing sensitive. Is there a way to flag them ...
11 years, 1 month ago (2009-10-26 18:13:07 UTC) #5
jam
Regarding the tests being timing sensitive, we aim for no flakey tests at all, since ...
11 years, 1 month ago (2009-10-26 18:48:36 UTC) #6
apatrick
The tests are time sensitive because they measure the time between scheduling the timer and ...
11 years, 1 month ago (2009-10-26 19:05:16 UTC) #7
jam
yeah, while the timing tests are of course nice, they will be flakey on different ...
11 years, 1 month ago (2009-10-26 19:31:11 UTC) #8
apatrick
Done. Do the trybots run the ui_tests?
11 years, 1 month ago (2009-10-26 20:05:22 UTC) #9
jam
11 years, 1 month ago (2009-10-26 20:24:16 UTC) #10
lgtm

yep the trybots run the ui_tests (you can see which tests ran on previous
patchsets by clicking on the win/linux/mac links)

Powered by Google App Engine
This is Rietveld 408576698