Issue 329007: Windows: Change test to not assume ebp is frame-pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329007: Windows: Change test to not assume ebp is frame-pointer. (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Visibility:
Public.

Description

Windows: Change test to not assume ebp is frame-pointer.

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	test/cctest/test-log-stack-tracer.cc	View		2 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Hi Mikhail I changed test-log-stack-tracer.cc/CFuncDoTrace to also work in Win64. Could you check if it ...

11 years, 2 months ago (2009-10-23 11:52:56 UTC) #1

mnaganov (inactive)

11 years, 2 months ago (2009-10-23 13:58:02 UTC) #2

LGTM

Hi Lasse,

This test is primarily intended for debug build, where FPO optimization is not
used. For a release build, it is still worth to check that sampler would not
crash being applied to a random memory fragment. So your change is pretty OK.
Thanks!

Expand Messages | Collapse Messages