Issue 3290021: Reflect the change of QualDbs location moved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3290021: Reflect the change of QualDbs location moved. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, josephsih1

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Reflect the change of QualDbs location moved. Reflect the change of https://chromereview.prom.corp.google.com/1638035 TEST=manaul - image_to_usb --factory - run factory test -- match HWID -- write GBB -- reboot -- check HW components

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -16 lines)			Patch
	M	mod_for_factory_scripts/500populateQualDbs	View	1	1 chunk	+8 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tammo Spalink

lgtm -- although i did have a nit-comment http://codereview.chromium.org/3290021/diff/1/2 File mod_for_factory_scripts/500populateQualDbs (right): http://codereview.chromium.org/3290021/diff/1/2#newcode15 mod_for_factory_scripts/500populateQualDbs:15: # ...

10 years, 3 months ago (2010-09-13 08:20:13 UTC) #2

Tom Wai-Hong Tam

10 years, 3 months ago (2010-09-13 18:48:28 UTC) #3

http://codereview.chromium.org/3290021/diff/1/2
File mod_for_factory_scripts/500populateQualDbs (right):

http://codereview.chromium.org/3290021/diff/1/2#newcode15
mod_for_factory_scripts/500populateQualDbs:15: # Ensure there is DB directory in
x86-agx and x86-mario.
Fixed.

Expand Messages | Collapse Messages