Issue 3290012: Avoid pushing arguments twice in GenericBinaryOpStub....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3290012: Avoid pushing arguments twice in GenericBinaryOpStub.... (Closed)

Created:
10 years, 3 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Avoid pushing arguments twice in GenericBinaryOpStub. Under some conditions (ADD, non-number arguments passed in registers) GenerateRegisterArgumentsPush was called twice and the stack broke. Committed: http://code.google.com/p/v8/source/detail?r=5422

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	A	test/mjsunit/regress/regress-push-args-twice.js	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM and thanks! But we do need a test case for this. -- Vitaly

10 years, 3 months ago (2010-09-07 12:48:31 UTC) #2

Vladislav Kaznacheev

10 years, 3 months ago (2010-09-07 12:51:21 UTC) #3

Added a test.
On 2010/09/07 12:48:31, Vitaly wrote:
> LGTM and thanks! But we do need a test case for this.
> 
> 
> -- Vitaly

Expand Messages | Collapse Messages