Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 3286002: Condense dev and factory install shim options (Closed)

Created:
10 years, 3 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Tan Gao, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

* Combine partition setting * Add dev-rec key to factory installer * rename factory_install_shim output to be consistent with dev install shim Change-Id: Ibf8f027edda67626af5c319b4daa164cb53ccfe7 BUG=4382 TEST=Build factory install, build dev install, build normal

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add key stuff #

Total comments: 8

Patch Set 4 : feedback for code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M build_image View 1 2 3 7 chunks +39 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nick Sanders
Combined factory and dev install setup
10 years, 3 months ago (2010-08-30 20:27:18 UTC) #1
sosa
LGTM after you address some nits. http://codereview.chromium.org/3286002/diff/5001/6001 File build_image (right): http://codereview.chromium.org/3286002/diff/5001/6001#newcode135 build_image:135: error "rootfs ($((FLAGS_rootfs_size ...
10 years, 3 months ago (2010-08-30 23:02:45 UTC) #2
Tan Gao
http://codereview.chromium.org/3286002/diff/5001/6001 File build_image (right): http://codereview.chromium.org/3286002/diff/5001/6001#newcode115 build_image:115: # dev image produced will be based on dev ...
10 years, 3 months ago (2010-08-30 23:38:59 UTC) #3
Nick Sanders
http://codereview.chromium.org/3286002/diff/5001/6001 File build_image (right): http://codereview.chromium.org/3286002/diff/5001/6001#newcode115 build_image:115: # dev image produced will be based on dev ...
10 years, 3 months ago (2010-08-31 01:02:49 UTC) #4
Nick Sanders
http://codereview.chromium.org/3286002/diff/5001/6001 File build_image (right): http://codereview.chromium.org/3286002/diff/5001/6001#newcode135 build_image:135: error "rootfs ($((FLAGS_rootfs_size + FLAGS_rootfs_hash_pad)) MiB) is \ On ...
10 years, 3 months ago (2010-08-31 01:03:12 UTC) #5
Tan Gao
10 years, 3 months ago (2010-08-31 01:09:51 UTC) #6
LGTM

Please do try it out to make sure the key signing stuff works as desired :-)

Powered by Google App Engine
This is Rietveld 408576698