Issue 3284005: base: Move SplitStringUsingSubstr functions from string_util.h to string_split.h

Issue 3284005: base: Move SplitStringUsingSubstr functions from string_util.h to string_split.h (Closed)

Created:
10 years, 3 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

base: Move SplitStringUsingSubstr functions from string_util.h to string_split.h BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58300

Patch Set 2 : fix base_unittests #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -88 lines)			Patch
M	base/string_split.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	base/string_split.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	base/string_split_unittest.cc	View	1	2 chunks	+48 lines, -0 lines	0 comments	Download
M	base/string_util.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/string_util.cc	View	1	1 chunk	+0 lines, -34 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1	1 chunk	+0 lines, -45 lines	0 comments	Download
M	net/http/http_request_headers.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

Hi Tim, this is an old TODO in string_util.h that I put there when doing ...

10 years, 3 months ago (2010-08-30 21:50:37 UTC) #1

tim (not reviewing)

http://codereview.chromium.org/3284005/diff/7001/8005 File base/string_util.h (right): http://codereview.chromium.org/3284005/diff/7001/8005#newcode533 base/string_util.h:533: void SplitStringDontTrim(const std::string& str, maybe these should go as ...

10 years, 3 months ago (2010-08-31 16:44:27 UTC) #2

tfarina

On 2010/08/31 16:44:27, timsteele wrote: > http://codereview.chromium.org/3284005/diff/7001/8005 > File base/string_util.h (right): > > http://codereview.chromium.org/3284005/diff/7001/8005#newcode533 > ...

10 years, 3 months ago (2010-08-31 17:01:04 UTC) #3

tim (not reviewing)

10 years, 3 months ago (2010-08-31 17:10:39 UTC) #4

On 2010/08/31 17:01:04, tfarina wrote:
> On 2010/08/31 16:44:27, timsteele wrote:
> > http://codereview.chromium.org/3284005/diff/7001/8005
> > File base/string_util.h (right):
> > 
> > http://codereview.chromium.org/3284005/diff/7001/8005#newcode533
> > base/string_util.h:533: void SplitStringDontTrim(const std::string& str,
> > maybe these should go as well?
> 
> Yup, but I just wanted to reduce the size of the CL. Putting it here would
make
> it worse. I think it will be more clear to do this in a next patch.

Ok, sure.  LGTM & thanks.

Expand Messages | Collapse Messages