Refactor paste and go out of AutocompleteEdit.

chrome/browser/autocomplete/autocomplete_edit.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/string_util.h"
 #include "chrome/browser/autocomplete/autocomplete_edit_view.h"
 #include "chrome/browser/autocomplete/autocomplete_popup_model.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/net/dns_global.h"
 #include "chrome/browser/net/url_fixer_upper.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_model.h"
+#include "chrome/browser/search_versus_navigate_classifier.h"
 #include "chrome/common/notification_service.h"
 #include "googleurl/src/gurl.h"
 #include "googleurl/src/url_util.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 ///////////////////////////////////////////////////////////////////////////////
 // AutocompleteEditModel
 
-// A single AutocompleteController used solely for making synchronous calls.  We
-// avoid using the popup's controller here because we don't want to interrupt
-// in-progress queries or modify the popup state.  We don't need a controller
-// for every edit because this will always be accessed on the main thread, so we
-// won't have thread-safety problems.
-static AutocompleteController* synchronous_controller = NULL;
-static int synchronous_controller_refcount = 0;
-
 AutocompleteEditModel::AutocompleteEditModel(
     AutocompleteEditView* view,
     AutocompleteEditController* controller,
     Profile* profile)
     : view_(view),
       popup_(NULL),
       controller_(controller),
       has_focus_(false),
       user_input_in_progress_(false),
       just_deleted_text_(false),
       has_temporary_text_(false),
       original_keyword_ui_state_(NORMAL),
       paste_state_(NONE),
       control_key_state_(UP),
       is_keyword_hint_(false),
       keyword_ui_state_(NORMAL),
       show_search_hint_(true),
       paste_and_go_transition_(PageTransition::TYPED),
       profile_(profile) {
-  if (++synchronous_controller_refcount == 1) {
-    // We don't have a controller yet, so create one.  No profile is set since
-    // we'll set this before each call to the controller.
-    synchronous_controller = new AutocompleteController(NULL);
-  }
-}
-
-AutocompleteEditModel::~AutocompleteEditModel() {
-  if (--synchronous_controller_refcount == 0)
-    delete synchronous_controller;
 }
 
 void AutocompleteEditModel::SetPopupModel(AutocompletePopupModel* popup_model) {
   popup_ = popup_model;
   registrar_.Add(this,
       NotificationType::AUTOCOMPLETE_CONTROLLER_DEFAULT_MATCH_UPDATED,
       Source<AutocompleteController>(popup_->autocomplete_controller()));
 }
 
 void AutocompleteEditModel::SetProfile(Profile* profile) {
@@ skipping 121 matching lines @@
 }
 
 void AutocompleteEditModel::StartAutocomplete(
     bool prevent_inline_autocomplete) const {
   popup_->StartAutocomplete(user_text_, GetDesiredTLD(),
       prevent_inline_autocomplete || just_deleted_text_ ||
       (paste_state_ != NONE), keyword_ui_state_ == KEYWORD);
 }
 
 bool AutocompleteEditModel::CanPasteAndGo(const std::wstring& text) const {
-  // Reset local state.
   paste_and_go_url_ = GURL();
   paste_and_go_transition_ = PageTransition::TYPED;
   paste_and_go_alternate_nav_url_ = GURL();
 
-  // Ask the controller what do do with this input.
-  // Setting the profile is cheap, and since there's one synchronous_controller
-  // for many tabs which may all have different profiles, it ensures we're
-  // always using the right one.
-  synchronous_controller->SetProfile(profile_);
-  synchronous_controller->Start(text, std::wstring(), true, false, true);
-  DCHECK(synchronous_controller->done());
-  const AutocompleteResult& result = synchronous_controller->result();
-  if (result.empty())
-    return false;
-
-  // Set local state based on the default action for this input.
-  const AutocompleteResult::const_iterator match(result.default_match());
-  DCHECK(match != result.end());
-  paste_and_go_url_ = match->destination_url;
-  paste_and_go_transition_ = match->transition;
-  paste_and_go_alternate_nav_url_ = result.alternate_nav_url();
+  profile_->GetSearchVersusNavigateClassifier()->Classify(text, std::wstring(),
+      NULL, &paste_and_go_url_, &paste_and_go_transition_, NULL,
+      &paste_and_go_alternate_nav_url_);
 
   return paste_and_go_url_.is_valid();
 }
 
 void AutocompleteEditModel::PasteAndGo() {
   // The final parameter to OpenURL, keyword, is not quite correct here: it's
   // possible to "paste and go" a string that contains a keyword.  This is
   // enough of an edge case that we ignore this possibility.
   view_->RevertAll();
   view_->OpenURL(paste_and_go_url_, CURRENT_TAB, paste_and_go_transition_,
@@ skipping 355 matching lines @@
     const std::wstring& text) const {
   return ((keyword_ui_state_ == NO_KEYWORD) || is_keyword_hint_ ||
           keyword_.empty()) ?
       text : (keyword_ + L" " + text);
 }
 
 GURL AutocompleteEditModel::GetURLForCurrentText(
     PageTransition::Type* transition,
     bool* is_history_what_you_typed_match,
     GURL* alternate_nav_url) const {
-  return (popup_->IsOpen() || query_in_progress()) ?
-      popup_->URLsForCurrentSelection(transition,
-                                      is_history_what_you_typed_match,
-                                      alternate_nav_url) :
-      URLsForDefaultMatch(transition, is_history_what_you_typed_match,
-                          alternate_nav_url);
+  if (popup_->IsOpen() || query_in_progress()) {
+    return popup_->URLsForCurrentSelection(transition,
+                                           is_history_what_you_typed_match,
+                                           alternate_nav_url);
+  }
+
+  GURL destination_url;
+  profile_->GetSearchVersusNavigateClassifier()->Classify(
+      UserTextFromDisplayText(view_->GetText()), GetDesiredTLD(), NULL,
+      &destination_url, transition, is_history_what_you_typed_match,
+      alternate_nav_url);
+  return destination_url;
 }
-
-GURL AutocompleteEditModel::URLsForDefaultMatch(
-    PageTransition::Type* transition,
-    bool* is_history_what_you_typed_match,
-    GURL* alternate_nav_url) const {
-  // Ask the controller what do do with this input.
-  // Setting the profile is cheap, and since there's one synchronous_controller
-  // for many tabs which may all have different profiles, it ensures we're
-  // always using the right one.
-  synchronous_controller->SetProfile(profile_);
-  synchronous_controller->Start(UserTextFromDisplayText(view_->GetText()),
-                                GetDesiredTLD(), true, false, true);
-  CHECK(synchronous_controller->done());
-
-  const AutocompleteResult& result = synchronous_controller->result();
-  if (result.empty())
-    return GURL();
-
-  // Get the URLs for the default match.
-  const AutocompleteResult::const_iterator match = result.default_match();
-  if (transition)
-    *transition = match->transition;
-  if (is_history_what_you_typed_match)
-    *is_history_what_you_typed_match = match->is_history_what_you_typed_match;
-  if (alternate_nav_url)
-    *alternate_nav_url = result.alternate_nav_url();
-  return match->destination_url;
-}