Issue 328017: Second attempt to swap processes on rel=noreferrer, target=blank links....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328017: Second attempt to swap processes on rel=noreferrer, target=blank links.... (Closed)

Created:
11 years, 2 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, Nate Chapin

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Second attempt to swap processes on rel=noreferrer, target=blank links. The test timed out on one of the bots last time. This change tries to fix that, and it breaks down the test into multiple tests to isolate the problem in case it isn't fixed. No changes to code outside the test and the test HTML file. Previous review at http://codereview.chromium.org/284015. BUG=24447 TEST=RenderViewHostManagerTest.*SwapProcess*

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -5 lines)			Patch
M	chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc	View	2 chunks	+131 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	5 chunks	+36 lines, -1 line	0 comments	Download
A +	chrome/test/data/click-noreferrer-links.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/api/public/WebFrame.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

After some distractions today, I'm trying to land this again. The test passed on everything ...

11 years, 2 months ago (2009-10-23 23:10:52 UTC) #1

OK, LGTM

Expand Messages | Collapse Messages