Issue 328002: Assertion failure fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328002: Assertion failure fix (Closed)

Created:
11 years, 2 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Charlie Lee (do not use)

CC:
chromium-reviews_googlegroups.com, sky

Visibility:
Public.

Description

Assertion failure fix * Closing a submenu was hitting NOTREACHED in OnMenuHidden. * Changed to register OnMenuHidden callback only when we're about to open the menu, then disconnect it when closed. This is safer as the same menu can be used as submenu (although that's probably not great style) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30061

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	views/controls/menu/native_menu_gtk.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages