Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 3278001: [Chrome OS] more of the ownership api (Closed)

Created:
10 years, 3 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
fes
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Chrome OS] more of the ownership api BUG=chromium-os:4488 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58275

Patch Set 1 #

Patch Set 2 : Ensure that only one call is in flight at a time #

Patch Set 3 : Re-upload previous patch #

Patch Set 4 : fix MockLoginLibrary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -12 lines) Patch
M chrome/browser/chromeos/cros/login_library.h View 1 chunk +46 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/login_library.cc View 1 5 chunks +110 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_login_library.h View 1 chunk +15 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Masone
10 years, 3 months ago (2010-08-27 18:42:54 UTC) #1
Chris Masone
On 2010/08/27 18:42:54, Chris Masone wrote: > +fes
10 years, 3 months ago (2010-08-31 00:11:11 UTC) #2
fes
LGTM, with one question: login assures that there is at max one outstanding request of ...
10 years, 3 months ago (2010-08-31 18:25:51 UTC) #3
Chris Masone
On 2010/08/31 18:25:51, fes wrote: > LGTM, with one question: login assures that there is ...
10 years, 3 months ago (2010-08-31 20:06:36 UTC) #4
Chris Masone
On 2010/08/31 20:06:36, Chris Masone wrote: > On 2010/08/31 18:25:51, fes wrote: > > LGTM, ...
10 years, 3 months ago (2010-08-31 20:52:55 UTC) #5
fes
10 years, 3 months ago (2010-08-31 20:57:55 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698