Follow Safari and Firefox in returning empty array from array splice...

Follow Safari and Firefox in returning empty array from array splice
with no arguments.


Committed: http://code.google.com/p/v8/source/detail?r=5375

[Rico, 2010-08-30 06:33:21]

Drive by.

http://codereview.chromium.org/3277005/diff/4001/5001
File src/array.js (left):

http://codereview.chromium.org/3277005/diff/4001/5001#oldcode572
src/array.js:572: // compatibility.
As far as I can see, they do actually follow the spec now. start and
delete_count will, if undefined, be converted to zero by the ToInteger call. If
both these are zero the empty array will be the result of splice.

[antonm, 2010-08-30 12:07:25]

I agree with Rico: apparently both Safari and FF just started to follow
ECMA-262, so we could just remove the comment.  And maybe even the condition
itself, if the rest of the code works fine for this case, which easily could be
the case (I hope it's a rare case and we shouldn't keep this condition as an
optimization).

BTW, couple of lines below there is a special treatment of missing delete count.
 I wonder if Safari or FF changed their behaviour as well (probably not for FF
as it wasn't the case for TraceMonkey).

[Mads Ager (chromium), 2010-08-30 15:07:19]

Thanks, please have another look.

Comments removed and condition removed from the JS code.

Regarding the difference with delete count, that still has special handling at
least in Firefox.

[antonm, 2010-08-30 15:12:04]

LGTM and thanks a lot for fixing it.