Issue 3276004: Simplify code by removing special-casing for single-character patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3276004: Simplify code by removing special-casing for single-character patterns (Closed)

Created:
10 years, 3 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify code by removing special-casing for single-character patterns Committed: http://code.google.com/p/v8/source/detail?r=5380

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -251 lines)			Patch
	M	src/runtime.cc	View	1 2 3	10 chunks	+33 lines, -251 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

I get around 6% slowdown on an artificial microbenchmark. On the other hand the lure ...

10 years, 3 months ago (2010-08-31 09:01:45 UTC) #3

sandholm

10 years, 3 months ago (2010-08-31 09:13:16 UTC) #4

http://codereview.chromium.org/3276004/diff/6001/7001
File src/runtime.cc (right):

http://codereview.chromium.org/3276004/diff/6001/7001#newcode2834
src/runtime.cc:2834: // We know our pattern is at least 2 characters, we cache
the first so
On 2010/08/31 09:01:45, Erik Corry wrote:
> Comment is wrong.

I added an assertion to make sure comment is correct. 
I also changed the loop back into a do-while to save checks.

Expand Messages | Collapse Messages