Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: run_remote_tests.sh

Issue 3276002: Script to generate post mortem of all crashes on device (Closed) Base URL: http://git.chromium.org/git/crosutils.git
Patch Set: Respond to reviews Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cros_show_stacks ('K') | « remote_access.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: run_remote_tests.sh
diff --git a/run_remote_tests.sh b/run_remote_tests.sh
index 9d3fa36d0e68162e9f14eead56742b7f7cc13a95..49ec752c050cfd055aebc80e2b52726047d5f83e 100755
--- a/run_remote_tests.sh
+++ b/run_remote_tests.sh
@@ -63,25 +63,6 @@ function cleanup() {
cleanup_remote_access
}
-# Returns an error if the test_result_file has text which indicates
-# the test was not run successfully.
-# Arguments:
-# $1 - file name of autotest status for to check for success
-# Returns:
-# None
-function is_successful_test() {
- local file="$1"
- # To be successful, must not have BAD, ERROR or FAIL in the file.
- if egrep -q "(BAD|ERROR|FAIL)" "${file}"; then
- return 1
- fi
- # To be successful, must have GOOD in the file.
- if ! grep -q GOOD "${file}"; then
- return 1
- fi
- return 0
-}
-
# Adds attributes to all tests run
# Arguments:
# $1 - results directory
@@ -103,20 +84,6 @@ function add_test_attribute() {
}
-# Ask the target what board it is
-function learn_board() {
- if [[ -n "${FLAGS_board}" ]]; then
- return
- fi
- remote_sh grep CHROMEOS_RELEASE_BOARD /etc/lsb-release
- FLAGS_board=$(echo "${REMOTE_OUT}" | cut -d= -f2)
- if [[ -z "${FLAGS_board}" ]]; then
- check_board
- fi
- echo "Target reports board is ${FLAGS_board}"
-}
-
-
# Determine if a control is for a client or server test. Echos
# either "server" or "client".
# Arguments:
« cros_show_stacks ('K') | « remote_access.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698