Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/debug.cc

Issue 3275011: Add breakOnCaughtException and breakOnUncaughtException flags (Closed)
Patch Set: merge Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug.h ('k') | src/debug-debugger.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1193 1193
1194 void Debug::ChangeBreakOnException(ExceptionBreakType type, bool enable) { 1194 void Debug::ChangeBreakOnException(ExceptionBreakType type, bool enable) {
1195 if (type == BreakUncaughtException) { 1195 if (type == BreakUncaughtException) {
1196 break_on_uncaught_exception_ = enable; 1196 break_on_uncaught_exception_ = enable;
1197 } else { 1197 } else {
1198 break_on_exception_ = enable; 1198 break_on_exception_ = enable;
1199 } 1199 }
1200 } 1200 }
1201 1201
1202 1202
1203 bool Debug::IsBreakOnException(ExceptionBreakType type) {
1204 if (type == BreakUncaughtException) {
1205 return break_on_uncaught_exception_;
1206 } else {
1207 return break_on_exception_;
1208 }
1209 }
1210
1211
1203 void Debug::PrepareStep(StepAction step_action, int step_count) { 1212 void Debug::PrepareStep(StepAction step_action, int step_count) {
1204 HandleScope scope; 1213 HandleScope scope;
1205 ASSERT(Debug::InDebugger()); 1214 ASSERT(Debug::InDebugger());
1206 1215
1207 // Remember this step action and count. 1216 // Remember this step action and count.
1208 thread_local_.last_step_action_ = step_action; 1217 thread_local_.last_step_action_ = step_action;
1209 if (step_action == StepOut) { 1218 if (step_action == StepOut) {
1210 // For step out target frame will be found on the stack so there is no need 1219 // For step out target frame will be found on the stack so there is no need
1211 // to set step counter for it. It's expected to always be 0 for StepOut. 1220 // to set step counter for it. It's expected to always be 0 for StepOut.
1212 thread_local_.step_count_ = 0; 1221 thread_local_.step_count_ = 0;
(...skipping 1834 matching lines...) Expand 10 before | Expand all | Expand 10 after
3047 { 3056 {
3048 Locker locker; 3057 Locker locker;
3049 Debugger::CallMessageDispatchHandler(); 3058 Debugger::CallMessageDispatchHandler();
3050 } 3059 }
3051 } 3060 }
3052 } 3061 }
3053 3062
3054 #endif // ENABLE_DEBUGGER_SUPPORT 3063 #endif // ENABLE_DEBUGGER_SUPPORT
3055 3064
3056 } } // namespace v8::internal 3065 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.h ('k') | src/debug-debugger.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698