Issue 3275011: Add breakOnCaughtException and breakOnUncaughtException flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3275011: Add breakOnCaughtException and breakOnUncaughtException flags (Closed)

Created:
10 years, 3 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Add breakOnCaughtException and breakOnUncaughtException flags Committed: http://code.google.com/p/v8/source/detail?r=5480

Patch Set 2 : Support enable/disable break on exception flag in protocol #

Total comments: 2

Patch Set 3 : rename enum constant #

Patch Set 4 : merge #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -4 lines)			Patch
M	src/debug.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/debug-debugger.js	View	1 2	4 chunks	+32 lines, -4 lines	0 comments	Download
M	src/runtime.h	View	2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	2 3	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM Thanks for adding this. http://codereview.chromium.org/3275011/diff/2001/3001 File src/debug-debugger.js (right): http://codereview.chromium.org/3275011/diff/2001/3001#newcode48 src/debug-debugger.js:48: Debug.ExceptionBreak = { All ...

10 years, 3 months ago (2010-09-16 21:09:29 UTC) #2

Peter Rybin

10 years, 3 months ago (2010-09-16 21:32:53 UTC) #3

http://codereview.chromium.org/3275011/diff/2001/3001
File src/debug-debugger.js (right):

http://codereview.chromium.org/3275011/diff/2001/3001#newcode48
src/debug-debugger.js:48: Debug.ExceptionBreak = { All : 0,
On 2010/09/16 21:09:29, Søren Gjesse wrote:
> How about renaming 'All' to 'Caught' then?

Done.