Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/objects.cc

Issue 3274008: Get gcc to check that we don't ignore return values of functions that can... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | src/utils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 namespace v8 { 48 namespace v8 {
49 namespace internal { 49 namespace internal {
50 50
51 // Getters and setters are stored in a fixed array property. These are 51 // Getters and setters are stored in a fixed array property. These are
52 // constants for their indices. 52 // constants for their indices.
53 const int kGetterIndex = 0; 53 const int kGetterIndex = 0;
54 const int kSetterIndex = 1; 54 const int kSetterIndex = 1;
55 55
56 56
57 static Object* CreateJSValue(JSFunction* constructor, Object* value) { 57 NOIGNORE static Object* CreateJSValue(JSFunction* constructor, Object* value) {
58 Object* result = Heap::AllocateJSObject(constructor); 58 Object* result = Heap::AllocateJSObject(constructor);
59 if (result->IsFailure()) return result; 59 if (result->IsFailure()) return result;
60 JSValue::cast(result)->set_value(value); 60 JSValue::cast(result)->set_value(value);
61 return result; 61 return result;
62 } 62 }
63 63
64 64
65 Object* Object::ToObject(Context* global_context) { 65 Object* Object::ToObject(Context* global_context) {
66 if (IsNumber()) { 66 if (IsNumber()) {
67 return CreateJSValue(global_context->number_function(), this); 67 return CreateJSValue(global_context->number_function(), this);
(...skipping 8820 matching lines...) Expand 10 before | Expand all | Expand 10 after
8888 if (break_point_objects()->IsUndefined()) return 0; 8888 if (break_point_objects()->IsUndefined()) return 0;
8889 // Single beak point. 8889 // Single beak point.
8890 if (!break_point_objects()->IsFixedArray()) return 1; 8890 if (!break_point_objects()->IsFixedArray()) return 1;
8891 // Multiple break points. 8891 // Multiple break points.
8892 return FixedArray::cast(break_point_objects())->length(); 8892 return FixedArray::cast(break_point_objects())->length();
8893 } 8893 }
8894 #endif 8894 #endif
8895 8895
8896 8896
8897 } } // namespace v8::internal 8897 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | src/utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698