Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/builtins.cc

Issue 3274008: Get gcc to check that we don't ignore return values of functions that can... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.h ('k') | src/debug.cc » ('j') | src/utils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 } 236 }
237 237
238 // Set length and elements on the array. 238 // Set length and elements on the array.
239 array->set_elements(FixedArray::cast(obj)); 239 array->set_elements(FixedArray::cast(obj));
240 array->set_length(len); 240 array->set_length(len);
241 241
242 return array; 242 return array;
243 } 243 }
244 244
245 245
246 static Object* AllocateJSArray() { 246 NOIGNORE static Object* AllocateJSArray() {
247 JSFunction* array_function = 247 JSFunction* array_function =
248 Top::context()->global_context()->array_function(); 248 Top::context()->global_context()->array_function();
249 Object* result = Heap::AllocateJSObject(array_function); 249 Object* result = Heap::AllocateJSObject(array_function);
250 if (result->IsFailure()) return result; 250 if (result->IsFailure()) return result;
251 return result; 251 return result;
252 } 252 }
253 253
254 254
255 static Object* AllocateEmptyJSArray() { 255 NOIGNORE static Object* AllocateEmptyJSArray() {
256 Object* result = AllocateJSArray(); 256 Object* result = AllocateJSArray();
257 if (result->IsFailure()) return result; 257 if (result->IsFailure()) return result;
258 JSArray* result_array = JSArray::cast(result); 258 JSArray* result_array = JSArray::cast(result);
259 result_array->set_length(Smi::FromInt(0)); 259 result_array->set_length(Smi::FromInt(0));
260 result_array->set_elements(Heap::empty_fixed_array()); 260 result_array->set_elements(Heap::empty_fixed_array());
261 return result_array; 261 return result_array;
262 } 262 }
263 263
264 264
265 static void CopyElements(AssertNoAllocation* no_gc, 265 static void CopyElements(AssertNoAllocation* no_gc,
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1535 if (entry->contains(pc)) { 1535 if (entry->contains(pc)) {
1536 return names_[i]; 1536 return names_[i];
1537 } 1537 }
1538 } 1538 }
1539 } 1539 }
1540 return NULL; 1540 return NULL;
1541 } 1541 }
1542 1542
1543 1543
1544 } } // namespace v8::internal 1544 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.h ('k') | src/debug.cc » ('j') | src/utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698