Issue 3273011: fix sign_to_ssd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3273011: fix sign_to_ssd (Closed)

Created:
10 years, 3 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Tan Gao

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

fix sign_to_ssd Change-Id: If642d664163f36b79e3b6d845de0025cc3dc0372 BUG=6264 TEST="resign an image"

Patch Set 2 : add error checking #

Total comments: 4

Patch Set 3 : feedback from codereview #

Patch Set 4 : rebase #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -19 lines)			Patch
	M	bin/cros_sign_to_ssd	View	1 2	1 chunk	+33 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

LGTM http://codereview.chromium.org/3273011/diff/2001/3001 File bin/cros_sign_to_ssd (right): http://codereview.chromium.org/3273011/diff/2001/3001#newcode48 bin/cros_sign_to_ssd:48: if [ ! -d "$VBOOT_DIR" ]; then nit: ...

10 years, 3 months ago (2010-08-31 18:21:50 UTC) #2

Nick Sanders

10 years, 3 months ago (2010-09-01 06:02:58 UTC) #3

http://codereview.chromium.org/3273011/diff/2001/3001
File bin/cros_sign_to_ssd (right):

http://codereview.chromium.org/3273011/diff/2001/3001#newcode48
bin/cros_sign_to_ssd:48: if [ ! -d "$VBOOT_DIR" ]; then
On 2010/08/31 18:21:50, gauravsh wrote:
> nit: for consistency with other scripts, all var names must have { } curly
> braces around them. So ${VBOOT_DIR}. So on for the rest of the script.

Done.

http://codereview.chromium.org/3273011/diff/2001/3001#newcode52
bin/cros_sign_to_ssd:52: TMP_IMAGE=/tmp/image.bin
On 2010/08/31 18:21:50, gauravsh wrote:
> not a part of the CL, but you should use mktemp to create a temp file to
prevent
> name conflicts

Done.