Make TPM datagrams const, since they cannot be modified in the RO firmware.

Make TPM datagrams const, since they cannot be modified in the RO firmware.

Change-Id: I7f135584536c7437824ae65f74a8f7ef27c28665

BUG=
TEST=

[Luigi Semenzato, 2010-08-31 21:45:36]

This is your change, so I don't expect too much resistance here.  In fact, LGTM,
really!

[Randall, 2010-08-31 21:59:06]

LGLMCL - LGTM

(looks just like my CL :)

[gauravsh, 2010-08-31 22:00:25]

Drive-by... Please fill in the BUG and TEST fields for all CLs. I believe there
is an open tracker issue for the TPM issue - it would be nice to have the BUG
field reflect that. 

This way the tracker issue will get updated with the CL description at check-in
and makes it easy to keep track of all associated CLs that got pushed to resolve
a particular issue.

[Luigi Semenzato, 2010-08-31 22:26:58]

There are 47 issues with the term "TPM" in them, but I couldn't find
one that refers to this.  Any suggestion?

On Tue, Aug 31, 2010 at 3:00 PM,  <gauravsh@chromium.org> wrote:
> Drive-by... Please fill in the BUG and TEST fields for all CLs. I believe
> there
> is an open tracker issue for the TPM issue - it would be nice to have the
> BUG
> field reflect that.
>
> This way the tracker issue will get updated with the CL description at
> check-in
> and makes it easy to keep track of all associated CLs that got pushed to
> resolve
> a particular issue.
>
> http://codereview.chromium.org/3271006/show
>

[gauravsh, 2010-08-31 22:37:20]

Potential candidates:

crosbug.com/6239 (TPM S3 save/restore)
crosbug.com/433 (comprehensive tpm qualification umbrella bug)

If there is no related bug, BUG=none is fine too.

(My comment was meant to not be specific to this particular CL. I have
seen a bunch of CLs pass by which didn't have the fields but had an
associated open bug. Since bugdroid now updates tracker issues, I have
found this very useful to follow progress, not to mention grouping
related CLs together.)

On Tue, Aug 31, 2010 at 3:26 PM, Luigi Semenzato <semenzato@chromium.org> wrote:
> There are 47 issues with the term "TPM" in them, but I couldn't find
> one that refers to this.  Any suggestion?
>
> On Tue, Aug 31, 2010 at 3:00 PM,  <gauravsh@chromium.org> wrote:
>> Drive-by... Please fill in the BUG and TEST fields for all CLs. I believe
>> there
>> is an open tracker issue for the TPM issue - it would be nice to have the
>> BUG
>> field reflect that.
>>
>> This way the tracker issue will get updated with the CL description at
>> check-in
>> and makes it easy to keep track of all associated CLs that got pushed to
>> resolve
>> a particular issue.
>>
>> http://codereview.chromium.org/3271006/show
>>
>



-- 
-g

[Luigi Semenzato, 2010-08-31 22:52:46]

OK.  In this particular case it's just a generic code
improvement---probably no attached bug.  But you're right, in general
it's a good idea to try and match to a bug.

On Tue, Aug 31, 2010 at 3:37 PM, Gaurav Shah <gauravsh@chromium.org> wrote:
> Potential candidates:
>
> crosbug.com/6239 (TPM S3 save/restore)
> crosbug.com/433 (comprehensive tpm qualification umbrella bug)
>
> If there is no related bug, BUG=none is fine too.
>
> (My comment was meant to not be specific to this particular CL. I have
> seen a bunch of CLs pass by which didn't have the fields but had an
> associated open bug. Since bugdroid now updates tracker issues, I have
> found this very useful to follow progress, not to mention grouping
> related CLs together.)
>
> On Tue, Aug 31, 2010 at 3:26 PM, Luigi Semenzato <semenzato@chromium.org>
wrote:
>> There are 47 issues with the term "TPM" in them, but I couldn't find
>> one that refers to this.  Any suggestion?
>>
>> On Tue, Aug 31, 2010 at 3:00 PM,  <gauravsh@chromium.org> wrote:
>>> Drive-by... Please fill in the BUG and TEST fields for all CLs. I believe
>>> there
>>> is an open tracker issue for the TPM issue - it would be nice to have the
>>> BUG
>>> field reflect that.
>>>
>>> This way the tracker issue will get updated with the CL description at
>>> check-in
>>> and makes it easy to keep track of all associated CLs that got pushed to
>>> resolve
>>> a particular issue.
>>>
>>> http://codereview.chromium.org/3271006/show
>>>
>>
>
>
>
> --
> -g
>