Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 327012: LTTF: Rebaseline 3 tests for Windows Vista.... (Closed)

Created:
11 years, 2 months ago by tkent
Modified:
9 years, 7 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Rebaseline 3 tests for Windows Vista. * LayoutTests/fast/forms/search-styled.html TEXTMETRIC::tmAveCharWidth for `Verdana' font returns different results in Windows XP and Vista, and the size of a text form field depends on it. * LayoutTests/fast/text/whitespace/026.html and basic/006.html These tests use U+00B7. The width of U+00B7 in `Times New Roman' font is 3 pixels in Windows XP, and 5 pixels in Windows Vista. BUG=21859 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30038

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -21 lines) Patch
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/forms/search-styled-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/forms/search-styled-expected.png View 1 Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/forms/search-styled-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/basic/006-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/basic/006-expected.png View 1 Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/basic/006-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/whitespace/026-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/whitespace/026-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/whitespace/026-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-styled-expected.checksum View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-styled-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-styled-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/basic/006-expected.checksum View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/basic/006-expected.png View 1 Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/basic/006-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/whitespace/026-expected.checksum View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/whitespace/026-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/whitespace/026-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
11 years, 2 months ago (2009-10-23 11:24:26 UTC) #1
Yuta Kitamura
Again paths for the last 3 files look strange. Please comfirm that this is okay. ...
11 years, 2 months ago (2009-10-26 05:44:46 UTC) #2
tkent
> Again paths for the last 3 files look strange. Please comfirm that this is ...
11 years, 1 month ago (2009-10-26 06:19:57 UTC) #3
Yuta Kitamura
11 years, 1 month ago (2009-10-26 08:33:21 UTC) #4
LGTM.

Sorry for delay of review. I was involved in a trouble that was caused by
Cygwin...

Powered by Google App Engine
This is Rietveld 408576698