Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 327008: Allocate global handles in chunks to make it faster. (Closed)

Created:
11 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev, Vitaly Repeshko
Visibility:
Public.

Description

Allocate global handles in chunks to make it faster.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -17 lines) Patch
M src/global-handles.h View 1 2 chunks +18 lines, -0 lines 2 comments Download
M src/global-handles.cc View 6 chunks +84 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
antonm
Guys, returning to old CL. I found that for some modification tests which create a ...
11 years, 2 months ago (2009-10-23 04:20:59 UTC) #1
Mads Ager (chromium)
LGTM with comments. The nodes per chunk number seems high. Isn't this going to waste ...
11 years, 2 months ago (2009-10-23 12:45:21 UTC) #2
antonm
Mads, thanks a lot for comments. http://codereview.chromium.org/327008/diff/1/3 File src/global-handles.cc (right): http://codereview.chromium.org/327008/diff/1/3#newcode236 Line 236: static const ...
11 years, 2 months ago (2009-10-23 13:04:25 UTC) #3
Mads Ager (chromium)
LGTM The new comment is helpful, thanks. We should measure the impact of different sizes ...
11 years, 2 months ago (2009-10-26 06:44:53 UTC) #4
antonm
11 years, 1 month ago (2009-10-26 11:53:35 UTC) #5
Halving the amount of handles per chunk and if performance would be fine,
submitting this.

Thanks a lot for review, Mads.

http://codereview.chromium.org/327008/diff/5001/6001
File src/global-handles.h (right):

http://codereview.chromium.org/327008/diff/5001/6001#newcode157
Line 157: // ny |next_free|:
On 2009/10/26 06:44:53, Mads Ager wrote:
> ny -> by

Done.

Powered by Google App Engine
This is Rietveld 408576698