Issue 3270012: factory_WriteGBB and hardware_Components support locating file using HWID.

Issue 3270012: factory_WriteGBB and hardware_Components support locating file using HWID. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

factory_WriteGBB and hardware_Components support locating file using HWID. The HWID value is obtained by previous hardware component matching. TEST=runin and final test in factory test BUG=chrome-os-partner:501 Change-Id: Ib0c0616518828383efe61e05e989e1b45a0f619b

Patch Set 1 #

Total comments: 2

Patch Set 2 : use shared_dict #

Patch Set 3 : fix tab #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	client/site_tests/factory_WriteGBB/factory_WriteGBB.py	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	client/site_tests/hardware_Components/hardware_Components.py	View	1 2	3 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tammo Spalink

http://codereview.chromium.org/3270012/diff/1/3 File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/3270012/diff/1/3#newcode302 client/site_tests/hardware_Components/hardware_Components.py:302: locate_file_using_hwid=False): if you include shared_dict, you can use that ...

10 years, 3 months ago (2010-09-01 06:02:15 UTC) #2

Tom Wai-Hong Tam

10 years, 3 months ago (2010-09-02 02:37:24 UTC) #3

lgtm

Expand Messages | Collapse Messages