Issue 3269005: Fixed tsan warnings in remoting_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3269005: Fixed tsan warnings in remoting_unittests (Closed)

Created:
10 years, 3 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov, Alpha Left Google

CC:
chromium-reviews, Alexander Potapenko, Alpha Left Google, Sergey Ulanov, dmac, pam+watch_chromium.org, awong, garykac, stuartmorgan+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fixed tsan warnings in remoting_unittests BUG=53766, 53837 TEST=remoting_unittests under tsan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58235

Patch Set 1 #

Patch Set 2 : - #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -14 lines)			Patch
M	remoting/jingle_glue/jingle_thread.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/valgrind/tsan/ignores.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/valgrind/tsan/suppressions_win32.txt	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM! I've also run remoting_unittests under TSan in hybrid mode (it finds more races, requires ...

10 years, 3 months ago (2010-09-01 15:54:31 UTC) #2

Timur Iskhodzhanov

Indeed, you should also wait for a review from someone familiar with the code On ...

10 years, 3 months ago (2010-09-01 16:17:57 UTC) #3

LGTM.

Expand Messages | Collapse Messages