Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 3262006: update_engine,rootdev: atomically add librootdev and add update_engine deps (Closed)

Created:
10 years, 3 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush
Visibility:
Public.

Description

update_engine,rootdev: atomically add librootdev and add update_engine deps Adds librootdev to /usr/lib and rootdev.h to /usr/include. Makes update_engine RDEP on rootdev. This will make it safe for the update_engine change to land which uses the new librootdev. TEST=built both with these ebuilds aqnd cros_workon BUG=chromium-os:5938 Change-Id: Ia2a0e84d171689f1bd0111a4c699930c5764c850

Patch Set 1 #

Patch Set 2 : add VERS-rX to the changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
A + chromeos-base/update_engine/update_engine-0.0.1-r52.ebuild View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos-base/update_engine/update_engine-9999.ebuild View 1 chunk +1 line, -0 lines 0 comments Download
A + sys-apps/rootdev/rootdev-0.0.1-r4.ebuild View 2 chunks +9 lines, -2 lines 0 comments Download
M sys-apps/rootdev/rootdev-9999.ebuild View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Will Drewry
10 years, 3 months ago (2010-08-30 16:28:22 UTC) #1
adlr
10 years, 3 months ago (2010-08-30 17:42:22 UTC) #2
LGTM

On Mon, Aug 30, 2010 at 9:28 AM, <wad@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> update_engine,rootdev: atomically add librootdev and add update_engine deps
>
> Adds librootdev to /usr/lib and rootdev.h to /usr/include.
> Makes update_engine RDEP on rootdev.
>
> This will make it safe for the update_engine change to land which uses the
> new
> librootdev.
>
> TEST=built both with these ebuilds aqnd cros_workon
> BUG=chromium-os:5938
>
> Change-Id: Ia2a0e84d171689f1bd0111a4c699930c5764c850
>
> Please review this at http://codereview.chromium.org/3262006/show
>
> SVN Base: http://git.chromium.org/git/chromiumos-overlay.git
>
> Affected files:
>  M chromeos-base/update_engine/update_engine-9999.ebuild
>  M sys-apps/rootdev/rootdev-9999.ebuild
>
>
> Index: chromeos-base/update_engine/update_engine-9999.ebuild
> diff --git a/chromeos-base/update_engine/update_engine-9999.ebuild
> b/chromeos-base/update_engine/update_engine-9999.ebuild
> index
>
df90df7791ae5a1a9bbad9b50351f7293bcabb3b..33c8b4ee32626c0ded96879d21d3310f0e764900
> 100644
> --- a/chromeos-base/update_engine/update_engine-9999.ebuild
> +++ b/chromeos-base/update_engine/update_engine-9999.ebuild
> @@ -22,6 +22,7 @@ RDEPEND="app-arch/bzip2
>        dev-libs/protobuf
>        dev-util/bsdiff
>        net-misc/curl
> +       sys-apps/rootdev
>        sys-libs/zlib"
>  DEPEND="chromeos-base/libchromeos
>        dev-cpp/gmock
> Index: sys-apps/rootdev/rootdev-9999.ebuild
> diff --git a/sys-apps/rootdev/rootdev-9999.ebuild
> b/sys-apps/rootdev/rootdev-9999.ebuild
> index
>
60c7415ec33b879999db11f0c2f475ae2bfdc9d7..2f2d2edf3558fd70f4d46c8c9017397990e2cbb0
> 100644
> --- a/sys-apps/rootdev/rootdev-9999.ebuild
> +++ b/sys-apps/rootdev/rootdev-9999.ebuild
> @@ -5,10 +5,10 @@ EAPI=2
>
>  inherit toolchain-funcs cros-workon
>
> -DESCRIPTION="display rootfs device"
> +DESCRIPTION="Chrome OS root block device tool/library"
>  HOMEPAGE="http://src.chromium.org"
>  SRC_URI=""
> -LICENSE="GPLv2"
> +LICENSE="BSD"
>  SLOT="0"
>  KEYWORDS="~amd64 ~x86 ~arm"
>  IUSE=""
> @@ -22,4 +22,11 @@ src_install() {
>        dodir /usr/bin
>        exeinto /usr/bin
>        doexe ${S}/rootdev
> +
> +       dodir /usr/lib
> +       dolib.so librootdev.so*
> +
> +       dodir /usr/include/rootdev
> +       insinto /usr/include/rootdev
> +       doins rootdev.h
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698