Delay OnClose actions.

Delay OnClose actions.

If we reset delegate_ in OnClose, some pending tasks for DoOnReceivedData
would fail to notify received data to the delegate.

Don't reset delegate_ and socket_ in OnClose. Do it in DoOnClose instead.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30036

[ukai, 2009-10-23 11:41:07]

This is another bug that run_webkit_tests.sh fails
in LayoutTests/websocket/tests/

[Yuzo, 2009-10-26 02:07:58]

http://codereview.chromium.org/326010/diff/1/2
File webkit/tools/test_shell/simple_socket_stream_bridge.cc (right):

http://codereview.chromium.org/326010/diff/1/2#newcode190
Line 190: CHECK(MessageLoop::current() == message_loop_);
You might want to comment on why NULLifying should
be done here.

Or, ideally, can you add a DCHECK to ascertain that there
is nothing else remains in the message loop (and hence it's
safe to NULLify delagate_ and socket_),
if reasonably possible?

[ukai, 2009-10-26 04:50:51]

http://codereview.chromium.org/326010/diff/1/2
File webkit/tools/test_shell/simple_socket_stream_bridge.cc (right):

http://codereview.chromium.org/326010/diff/1/2#newcode190
Line 190: CHECK(MessageLoop::current() == message_loop_);
On 2009/10/26 02:07:59, Yuzo wrote:
> You might want to comment on why NULLifying should
> be done here.
> 
> Or, ideally, can you add a DCHECK to ascertain that there
> is nothing else remains in the message loop (and hence it's
> safe to NULLify delagate_ and socket_),
> if reasonably possible?
> 

Done.

[tyoshino (SeeGerritForStatus), 2009-10-26 05:09:03]

LGTM

http://codereview.chromium.org/326010/diff/3001/4001
File webkit/tools/test_shell/simple_socket_stream_bridge.cc (right):

http://codereview.chromium.org/326010/diff/3001/4001#newcode202
Line 202: // Don't handle OnClose if there is pending tasks.
there are

http://codereview.chromium.org/326010/diff/3001/4001#newcode206
Line 206: socket_ = NULL;
Maybe, it's better to nullify only socket_ in OnClose since it's used in IO
thread.

[Yuzo, 2009-10-26 05:14:15]

LGTM

[ukai, 2009-10-26 05:15:02]

http://codereview.chromium.org/326010/diff/3001/4001
File webkit/tools/test_shell/simple_socket_stream_bridge.cc (right):

http://codereview.chromium.org/326010/diff/3001/4001#newcode202
Line 202: // Don't handle OnClose if there is pending tasks.
On 2009/10/26 05:09:03, tyoshino wrote:
> there are

Done.

http://codereview.chromium.org/326010/diff/3001/4001#newcode206
Line 206: socket_ = NULL;
On 2009/10/26 05:09:03, tyoshino wrote:
> Maybe, it's better to nullify only socket_ in OnClose since it's used in IO
> thread.

Done.