Fix read loop in SocketStream.

Fix DoReadWrite loop in SocketStream.

If Read in DoReadWrite succeeded synchronously, it failed to call next Read.
Changed to call Read repeatedly after a Read finished both in synchronous return and asynchronous return.

Also fixes Write case as well.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30034

[ukai, 2009-10-23 11:35:09]

This is one of bugs that run_webkit_tests.sh fails in
LayoutTests/websocket/tests/.

[Yuzo, 2009-10-26 01:52:11]

http://codereview.chromium.org/326009/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/326009/diff/1/2#newcode606
Line 606: return result;
if result==ERR_IO_PENDING for read but
result!=ERR_IO_PENDING for write,
the returned value from the function is not ERR_IO_PENDING.

Is this expected?

[tyoshino (SeeGerritForStatus), 2009-10-26 02:57:47]

http://codereview.chromium.org/326009/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/326009/diff/1/2#newcode606
Line 606: return result;
On 2009/10/26 01:52:13, Yuzo wrote:
> if result==ERR_IO_PENDING for read but
> result!=ERR_IO_PENDING for write,
> the returned value from the function is not ERR_IO_PENDING.
> 
> Is this expected?

I believe this change is correct and should be mentioned in the CL description
as well as Read op case. When Write operation on the socket_ is completed
synchronously, we should return non ERR_IO_PENDING value to continue processing.

I think return value from DoSomething should be normalized to State value. So,
how about returning OK from here?

[ukai, 2009-10-26 05:01:53]

http://codereview.chromium.org/326009/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/326009/diff/1/2#newcode606
Line 606: return result;
On 2009/10/26 01:52:13, Yuzo wrote:
> if result==ERR_IO_PENDING for read but
> result!=ERR_IO_PENDING for write,
> the returned value from the function is not ERR_IO_PENDING.
> 
> Is this expected?

yes. if read is pending and write ends synchronously, we want to call
DoReadWrite() (hence Write) again (or close by error) in next loop in DoLoop().

http://codereview.chromium.org/326009/diff/1/2#newcode606
Line 606: return result;
On 2009/10/26 02:57:47, tyoshino wrote:
> On 2009/10/26 01:52:13, Yuzo wrote:
> > if result==ERR_IO_PENDING for read but
> > result!=ERR_IO_PENDING for write,
> > the returned value from the function is not ERR_IO_PENDING.
> > 
> > Is this expected?
> 
> I believe this change is correct and should be mentioned in the CL description
> as well as Read op case. When Write operation on the socket_ is completed
> synchronously, we should return non ERR_IO_PENDING value to continue
processing.

Updated.

> 
> I think return value from DoSomething should be normalized to State value. So,
> how about returning OK from here?

Sure.

[tyoshino (SeeGerritForStatus), 2009-10-26 05:12:37]

LGTM

[Yuzo, 2009-10-26 05:14:33]

LGTM