Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 326001: Adding support for windows safari. This requires registering the o3d plugin w... (Closed)

Created:
11 years, 2 months ago by vangelis
Modified:
9 years, 7 months ago
Reviewers:
gman1, Greg Spencer
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Adding support for windows safari. This requires registering the o3d plugin with firefox (via registry entries) and adding Safari to the list of supported User Agents.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M installer/win/o3d.wxs View 1 1 chunk +13 lines, -0 lines 0 comments Download
M plugin/cross/config_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M plugin/win/config.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vangelis
11 years, 2 months ago (2009-10-22 23:13:39 UTC) #1
gman
http://codereview.chromium.org/326001/diff/1/3 File plugin/win/config.cc (right): http://codereview.chromium.org/326001/diff/1/3#newcode85 Line 85: if (user_agent.find("Firefox") == user_agent.npos && I just have ...
11 years, 2 months ago (2009-10-23 00:00:09 UTC) #2
vangelis
http://codereview.chromium.org/326001/diff/1/3 File plugin/win/config.cc (right): http://codereview.chromium.org/326001/diff/1/3#newcode85 Line 85: if (user_agent.find("Firefox") == user_agent.npos && The problem is ...
11 years, 2 months ago (2009-10-23 01:19:55 UTC) #3
vangelis
11 years, 1 month ago (2009-10-27 19:33:26 UTC) #4
Are we ok with checking this in or do you feel strongly about changing the
browser whitelist method?

Powered by Google App Engine
This is Rietveld 408576698