Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 3260001: Force relinking of paged space if first attempt to recommit from space fails. (Closed)

Created:
10 years, 3 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Force relinking of paged space if first attempt to recommit from space fails. That could improve chances for commit success as currently, if we moved free pages out of order, we cannot shrink spaces. However, when we experience problems commiting from space back, we should use most of resources at our disposal. Also get rid of currently unused parameter to DeallocateFunction. Committed: http://code.google.com/p/v8/source/detail?r=5372

Patch Set 1 #

Total comments: 2

Patch Set 2 : Virtualizing block deallocation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -166 lines) Patch
M src/heap.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/mark-compact.h View 1 2 chunks +0 lines, -36 lines 0 comments Download
M src/mark-compact.cc View 1 7 chunks +12 lines, -68 lines 0 comments Download
M src/spaces.h View 1 4 chunks +14 lines, -0 lines 0 comments Download
M src/spaces.cc View 1 3 chunks +95 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Slava, may you have a look? Maybe newly added function should be rather named EnsureInChunkOrder. ...
10 years, 3 months ago (2010-08-27 12:43:15 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM with comment addressed. Thanks for cleaning debris left after me! http://codereview.chromium.org/3260001/diff/1/4 File src/mark-compact.h (right): ...
10 years, 3 months ago (2010-08-27 14:14:46 UTC) #2
Vyacheslav Egorov (Chromium)
10 years, 3 months ago (2010-08-27 14:16:29 UTC) #3
http://codereview.chromium.org/3260001/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/3260001/diff/1/2#newcode544
src/heap.cc:544: Heap::old_pointer_space()->RelinkPageListInChunkOrder(
After turning block deallocation into virtual method. This might be turned into
simple loop over paged spaces.

Powered by Google App Engine
This is Rietveld 408576698