Issue 3259011: AU: Start an UpdateAttempter unit test suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3259011: AU: Start an UpdateAttempter unit test suite. (Closed)

Created:
10 years, 3 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Start an UpdateAttempter unit test suite. This increases the UpdateAttmpter line coverage to almost 40%. More is needed but this is a good starting point / checkpoint. Also some UpdateCheckScheduler unit test cleanup. BUG=6243 TEST=unit tests, gmerge on device Change-Id: I39c80de3f18095c4a28cb36ab868bed6d7073824

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+301 lines, -83 lines)			Patch
M	SConstruct	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	action_mock.h	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	action_processor.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
A	action_processor_mock.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	download_action.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	update_attempter.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	update_attempter.cc	View	5 chunks	+8 lines, -7 lines	0 comments	Download
A	update_attempter_unittest.cc	View	1 chunk	+156 lines, -0 lines	0 comments	Download
M	update_check_scheduler_unittest.cc	View	7 chunks	+72 lines, -71 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Thanks for doing this!

Expand Messages | Collapse Messages