Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 3259010: Don't treat input with a scheme that's not "http" or "https" as a potential k... (Closed)

Created:
10 years, 3 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Don't treat input with a scheme that's not "http" or "https" as a potential keyword search. BUG=27038 TEST=Type in "site:yahoo.com foo". You should not go into keyword search mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58248

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/browser/autocomplete/keyword_provider.cc View 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
10 years, 3 months ago (2010-08-31 20:32:56 UTC) #1
sky
10 years, 3 months ago (2010-08-31 20:47:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698