chrome/browser/platform_util_win.cc - Issue 3259005: Remove the default argument from RegKey::ReadValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/platform_util_win.cc

Issue 3259005: Remove the default argument from RegKey::ReadValue. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: browser fixes Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/platform_util_win.cc

diff --git a/chrome/browser/platform_util_win.cc b/chrome/browser/platform_util_win.cc

index d932b7446d8f05c653efae685e2c95f9192f0d2f..a807a428a4a82f0b469205845b11532bb73fcffa 100644

--- a/chrome/browser/platform_util_win.cc

+++ b/chrome/browser/platform_util_win.cc

@@ -116,7 +116,7 @@ void OpenExternal(const GURL& url) {

key.Open(HKEY_CLASSES_ROOT, registry_path.c_str(), KEY_READ);

if (key.Valid()) {

DWORD size = 0;

- key.ReadValue(NULL, NULL, &size);

+ key.ReadValue(NULL, NULL, &size, NULL);

if (size <= 2) {

// ShellExecute crashes the process when the command is empty.

// We check for "2" because it always returns the trailing NULL.