Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: base/registry.h

Issue 3259005: Remove the default argument from RegKey::ReadValue. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: browser fixes Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/importer/ie_importer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/registry.h
diff --git a/base/registry.h b/base/registry.h
index 22ec0be1fff720a90eeb5e056534ee18f19b01cc..7584de019aa79f0c6e38c1e66a5855e05ccf8b3b 100644
--- a/base/registry.h
+++ b/base/registry.h
@@ -7,14 +7,10 @@
#pragma once
#include <windows.h>
-
#include <string>
#include "base/basictypes.h"
-// TODO(tfarina): Get rid of all the default arguments used in this file.
-// They are not allowed by our style guide.
-
// Utility class to read, write and manipulate the Windows Registry.
// Registry vocabulary primer: a "key" is like a folder, in which there
// are "values", which are <name, data> pairs, with an associated data type.
@@ -56,8 +52,7 @@ class RegKey {
bool ValueExists(const wchar_t* name);
- bool ReadValue(const wchar_t* name, void* data, DWORD* dsize,
- DWORD* dtype = NULL);
+ bool ReadValue(const wchar_t* name, void* data, DWORD* dsize, DWORD* dtype);
bool ReadValue(const wchar_t* name, std::wstring* value);
bool ReadValueDW(const wchar_t* name, DWORD* value);
« no previous file with comments | « no previous file | chrome/browser/importer/ie_importer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698