Issue 3258009: Linux: include an updated copy of xdg-mime that fixes default browser selection on KDE 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3258009: Linux: include an updated copy of xdg-mime that fixes default browser selection on KDE 4. (Closed)

Created:
10 years, 3 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Linux: include an updated copy of xdg-mime that fixes default browser selection on KDE 4. This should probably wait until after we branch for M7 this week. BUG=18106, 33842 TEST=default browser selection works in KDE 4 on distributions shipping CVS xdg-mime Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58449

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/tools/build/linux/chrome-wrapper	View	5 chunks	+12 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 3 months ago (2010-08-31 20:50:56 UTC) #2

LGTM

http://codereview.chromium.org/3258009/diff/1/5
File chrome/tools/build/linux/chrome-wrapper (right):

http://codereview.chromium.org/3258009/diff/1/5#newcode70
chrome/tools/build/linux/chrome-wrapper:70: # our path already exists, we leave
it where it is, to allow overriding this.
Can you add a note to say we'll flip the ordering of $PATH and $HERE back when
most Linux distros have picked up our xdg changes?

Expand Messages | Collapse Messages