Issue 3257011: Registered the service process to AutoRun (for Windows) if any service (Cloud...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3257011: Registered the service process to AutoRun (for Windows) if any service (Cloud... (Closed)

Created:
10 years, 3 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
Scott Byer, Alpha Left Google

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Registered the service process to AutoRun (for Windows) if any service (CloudPrint or Remoting) is enabled. When all services are disabled, we delete the AutoRun key. Also remembered the enabled state of the Cloud Print Proxy in the service prefs. BUG=None TEST=After enabling cloud print or chromoting on Windows, the service process should auto start on user login. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58246

Patch Set 1 #

Patch Set 2 : Fixed lint errors #

Patch Set 3 : Fixed Linux compile #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -19 lines)			Patch
M	base/win_util.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	base/win_util.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/service/service_process_control.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/common/service_process_util.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
MM	chrome/common/service_process_util.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.h	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/service/service_process.h	View		5 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/service/service_process.cc	View	1 2	5 chunks	+80 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sanjeevr

Did some rudimentary testing. Haven't tested all cases yet, will do so soon. But you ...

10 years, 3 months ago (2010-09-01 00:15:49 UTC) #1

Scott Byer

10 years, 3 months ago (2010-09-01 19:04:36 UTC) #3

LGTM

On 2010/09/01 00:15:49, sanjeevr wrote:
> Did some rudimentary testing. Haven't tested all cases yet, will do so soon.
But
> you can start reviewing the code.

Expand Messages | Collapse Messages