Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: bin/cbuildbot.py

Issue 3255004: Fix cleanup so we don't have to clobber as much when failures occur (Closed) Base URL: http://git.chromium.org/git/crosutils.git
Patch Set: Fix ws Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/cros_build_lib.py » ('j') | lib/cros_build_lib.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cbuildbot.py
diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
index 103d5126de5030beac32af3847a71d97472d49ad..86e498047b66b2a51248026e761ffd4fa51c74b6 100755
--- a/bin/cbuildbot.py
+++ b/bin/cbuildbot.py
@@ -216,6 +216,7 @@ def _FullCheckout(buildroot, rw_checkout=True, retries=_DEFAULT_RETRIES):
def _IncrementalCheckout(buildroot, rw_checkout=True,
retries=_DEFAULT_RETRIES):
"""Performs a checkout without clobbering previous checkout."""
+ _UprevCleanup(buildroot, error_ok=True)
RepoSync(buildroot, rw_checkout, retries)
@@ -281,12 +282,12 @@ def _UprevPackages(buildroot, revisionfile, board):
_UprevAllPackages(buildroot)
-def _UprevCleanup(buildroot):
+def _UprevCleanup(buildroot, error_ok=False):
"""Clean up after a previous uprev attempt."""
cwd = os.path.join(buildroot, 'src', 'scripts')
RunCommand(['./cros_mark_as_stable', '--srcroot=..',
'--tracking_branch="cros/master"', 'clean'],
- cwd=cwd)
+ cwd=cwd, error_ok=error_ok)
def _UprevPush(buildroot):
« no previous file with comments | « no previous file | lib/cros_build_lib.py » ('j') | lib/cros_build_lib.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698