Issue 3255004: Fix cleanup so we don't have to clobber as much when failures occur

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3255004: Fix cleanup so we don't have to clobber as much when failures occur (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Fix cleanup so we don't have to clobber as much when failures occur Change-Id: I120c49a38d2a17a2216296a68378fee7345f616a TBR=petkov

Patch Set 1 #

Patch Set 2 : Fix ws #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
	M	bin/cbuildbot.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	lib/cros_build_lib.py	View	1	2 chunks	+16 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 3 months ago (2010-08-31 16:27:19 UTC) #2

LGTM

http://codereview.chromium.org/3255004/diff/1001/2002
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/3255004/diff/1001/2002#newcode59
lib/cros_build_lib.py:59: except Exception,e:
space after ,

Expand Messages | Collapse Messages