Issue 3254010: Remove assertion that is no longer valid in InitializeStringSearch....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3254010: Remove assertion that is no longer valid in InitializeStringSearch.... (Closed)

Created:
10 years, 3 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
sandholm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove assertion that is no longer valid in InitializeStringSearch. This assertion is no longer valid because r5380 changes the assumption about the pat parameter. In addition, we embed the no allocation part of StringSplit in a block to reenable allocation later in that method. Committed: http://code.google.com/p/v8/source/detail?r=5381

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -27 lines)			Patch
	M	src/runtime.cc	View	1	2 chunks	+31 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM and thanks for fixing.

Expand Messages | Collapse Messages