Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 3251002: Add var for googlecode URL. (Closed)

Created:
10 years, 3 months ago by tessamac
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add var for googlecode URL. Contributed by tessamac@chromium.org BUG=52805 TEST=Check that DEPS urls are still constructed correctly with gclient sync --force. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58447

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M DEPS View 1 2 3 4 8 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tessamac
Let me know if this is what you had in mind.
10 years, 3 months ago (2010-08-27 19:10:48 UTC) #1
nsylvain
Yep, thanks! Can you try to switch the var locally to svn://svn.chromium.org/%s and do a ...
10 years, 3 months ago (2010-08-27 19:45:07 UTC) #2
tessamac
Updated, tested with gclient sync --force, and uploaded. http://codereview.chromium.org/3251002/diff/1/2 File DEPS (right): http://codereview.chromium.org/3251002/diff/1/2#newcode61 DEPS:61: (Var("googlecode_url") ...
10 years, 3 months ago (2010-08-30 18:45:37 UTC) #3
nsylvain
LGTM!
10 years, 3 months ago (2010-08-30 20:32:11 UTC) #4
tessamac
I synced and uploaded so if it still looks good would you mind committing for ...
10 years, 3 months ago (2010-09-01 20:40:41 UTC) #5
nsylvain
On Wed, Sep 1, 2010 at 1:40 PM, <tessamac@google.com> wrote: > I synced and uploaded ...
10 years, 3 months ago (2010-09-01 20:43:23 UTC) #6
tessamac
Oh nice! (Completely missed that email, oops!) I think I need to set up a ...
10 years, 3 months ago (2010-09-01 20:52:19 UTC) #7
nsylvain
10 years, 3 months ago (2010-09-01 20:57:41 UTC) #8
On Wed, Sep 1, 2010 at 1:52 PM, Tessa MacDuff <tessamac@google.com> wrote:

> Oh nice!  (Completely missed that email, oops!)  I think I need to set up a
> new client (since the one I've been using in read-only) and then patch this
> in.  Hopefully that will be easy and I can send you the buildbot changes
> soon.  Thanks for the help!

Let me know if you need help setting up your new client

Nicolas


>
>
> On Wed, Sep 1, 2010 at 13:42, Nicolas Sylvain <nsylvain@google.com> wrote:
>
>>
>>
>> On Wed, Sep 1, 2010 at 1:40 PM, <tessamac@google.com> wrote:
>>
>>> I synced and uploaded so if it still looks good would you mind committing
>>> for
>>> me?  (Then I can test my changes to buildbot.)
>>
>> You can commit yourself now ;)
>>
>>
>>>
>>>
>>> http://codereview.chromium.org/3251002/show
>>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698